fix(e2e-tests): close the focus-mode modal COMPASS-8820 #6615
Conversation
mabaasit
changed the title
| // As the tooltip disappeared at this point, the previousButton still | ||
| // has the focus. Pressing escape twice, should close the modal. | ||
| await browser.keys([Key.Escape]); | ||
| await sleep(100); | ||
| await browser.keys([Key.Escape]); |
There was a problem hiding this comment.
Maybe there is a way for us to do it without an arbitrary timeout, like removing the focus from the button? Also just generally wondering why button is swallowing the Esc keypress in this case, is this a bug? Nevermind this part, I tried it out and can see how this happens, just wasn't clear for me from the comment in the code: tooltip shows and this first esc press closes the tooltip.
There was a problem hiding this comment.
Yeah, i can try to remove the focus from it. I think it has to do with tooltip. I tried to re-create this here, with two different versions - one with tooltip and one without tooltip and the one with tooltip has this issue.
There was a problem hiding this comment.
i think without complicating it even more, i'd do as we do at other places, close the modal using its close button.
This test has been flaking a lot due to modal not closing as we press the escape.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes